Forward compatibility with react/promise 3#33
Merged
clue merged 1 commit intoreactphp:1.xfrom Sep 11, 2022
Merged
Conversation
Member
|
@WyriHaximus Good initiative and would love to see this getting some traction again! What are your plans for this PR? It looks like all outstanding PRs have been merged in the meantime? (reactphp/dns#153, reactphp/promise-timer#55, reactphp/promise-timer#54, reactphp/promise-timer#37) |
WyriHaximus
force-pushed
the
promise-3
branch
2 times, most recently
from
d45b662 to
98ab0fd
Compare
WyriHaximus
changed the title
WyriHaximus
force-pushed
the
promise-3
branch
from
98ab0fd to
74c95d1
Compare
Member
Author
|
@clue https://github.com/reactphp/datagram/actions/runs/3024442084 shows it passing with promise v3 (@dev) working for supported PHP versions. |
WyriHaximus
force-pushed
the
promise-3
branch
2 times, most recently
from
ba04c8c to
1635cc1
Compare
clue
reviewed
Sep 10, 2022
WyriHaximus
force-pushed
the
promise-3
branch
from
1635cc1 to
b3e9ca1
Compare
clue
approved these changes
Sep 11, 2022
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.